feat(migration): rewrite tsdown/client and vite/client in tsconfig compilerOptions.types#1542
Merged
fengmk2 merged 9 commits intoMay 11, 2026
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 299a3f8bd0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
naokihaba
force-pushed
the
fix/1502-rewrite-tsconfig-types
branch
from
299a3f8 to
d01b647
Compare
fengmk2
approved these changes
May 11, 2026
Member
|
@naokihaba I'm going to merge, what order should I merge these 3 PRs in? |
Collaborator
Author
Thanks! Could you merge #1501 first? The tests for #1541 and #1542 won't pass until #1501 is in main. After that's merged, feel free to pull in the other two whenever you're ready. |
fengmk2
added
test: e2e
fengmk2
pushed a commit
that referenced
this pull request
May 11, 2026
…ements (#1541) resolves #1502 This PR depends on #1501. When you're ready, please make sure #1501, #1541, and #1542 are all merged together. I originally thought about including this in #1501, but I decided to pull it into a separate PR so the scope wouldn't get too wide. I figured it would be easier to review if we kept the Rust and TypeScript changes apart rather than mixing them into one. Let me know if you’d prefer a different merge strategy and I can easily adjust things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1502
This PR depends on #1501. When you're ready to merge, please make sure #1501, #1541, and #1542 are all merged at the same time.
I thought about putting this together with #1501, but I decided to keep it separate so the scope didn't get too messy. I wanted to keep the Rust and TypeScript parts in different PRs to make the review a bit easier for everyone.
If you’d prefer to have these combined for the merge, just let me know and I can adjust it.